Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for Firebolt rpc 2.0 #677

Merged
merged 8 commits into from
Nov 21, 2024
Merged

feat: Support for Firebolt rpc 2.0 #677

merged 8 commits into from
Nov 21, 2024

Conversation

satlead
Copy link
Collaborator

@satlead satlead commented Nov 11, 2024

What

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@satlead satlead marked this pull request as ready for review November 11, 2024 20:01
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.sdk.src.api.manifest 91% ✔
core.main.src.utils 26% ❌
core.sdk.src.extn 83% ✔
core.sdk.src.api.device 77% ✔
core.sdk.src.api.observability 61% ➖
device.mock_device.src 52% ➖
core.sdk.src.utils 49% ➖
device.thunder_ripple_sdk.src.processors 9% ❌
core.main.src.service.apps 47% ➖
core.main.src.firebolt.handlers 9% ❌
core.main.src.processor 0% ❌
core.main.src.service.extn 40% ❌
core.sdk.src.extn.client 91% ✔
core.main.src.bootstrap 0% ❌
core.main.src.bootstrap.manifest 0% ❌
core.tdk.src.utils 0% ❌
core.sdk.src.api.firebolt 77% ✔
core.main.src.state 23% ❌
core.sdk.src.extn.ffi 80% ✔
device.thunder_ripple_sdk.src 15% ❌
distributor.general.src 2% ❌
core.main.src 0% ❌
core.tdk.src.gateway 100% ✔
device.thunder_ripple_sdk.src.client 74% ➖
device.thunder.src 0% ❌
core.main.src.firebolt 3% ❌
device.thunder.src.bootstrap 0% ❌
core.main.src.service 31% ❌
core.main.src.broker.thunder 22% ❌
core.main.src.bootstrap.extn 0% ❌
core.sdk.src.api.gateway 70% ➖
core.launcher.src.manager 7% ❌
core.main.src.broker 43% ➖
core.sdk.src.framework 75% ➖
device.thunder_ripple_sdk.src.events 4% ❌
core.sdk.src.api.distributor 84% ✔
device.thunder_ripple_sdk.src.processors.events 0% ❌
openrpc_validator.src 73% ➖
core.sdk.src.api 78% ✔
core.launcher.src 0% ❌
core.main.src.processor.storage 0% ❌
core.main.src.state.cap 43% ➖
Summary 43% (18561 / 43555) ➖

Minimum allowed line rate is 42%

@brendanobra brendanobra merged commit 7595754 into main Nov 21, 2024
7 checks passed
brendanobra added a commit that referenced this pull request Nov 21, 2024
@brendanobra
Revert "feat: Support for Firebolt rpc 2.0 (#677)"
b1254a0 
This reverts commit 7595754.
@brendanobra brendanobra mentioned this pull request Nov 21, 2024
Merged
brendanobra added a commit that referenced this pull request Nov 22, 2024
@brendanobra
Revert "feat: Support for Firebolt rpc 2.0" (#686)
f92c7b2 
Revert "feat: Support for Firebolt rpc 2.0 (#677)"

This reverts commit 7595754.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B-Larsen B-Larsen B-Larsen approved these changes

@pahearn73 pahearn73 pahearn73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satlead @pahearn73 @B-Larsen @brendanobra